Warfish Addons - Bug Reports and Feature Requests

[IRoll11s]

Warfish Interface Enhancements
¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
A userscript that extends the capabilities of the Warfish website.
The latest version of this script is hosted on userscripts.org and can be found HERE.
To use this script you need Firefox version 3.0 or higher with the GreaseMonkey Addon installed.
Below are screenshots of some MAJOR improvements you will instantly see upon installation:

Warfish General Interface Upgrade:


New In-Game map Status and History:


New In-Game About and Rules Check:


Add Profile Labels:


New Quickpick View with Names and Labels:


View your Friend's List:


Menu Commands:


Menu commands can be run by right clicking the monkey head. There are 4 commands:

Show latest update information:
Available from any page, shows the changes to the script since the last update.

Restore last message:
Available from any page that has a form for submitting messages to other players,
including the messages tab, tournament and game board pages. Message is saved
whenever you click the POST button. If your post doesn't go through for any reason,
use this to get it back.

Clear saved game information:
Available on any game board page. The script saves information for each game for
use in the Board Status and History. Use this option if you have a bunch of players with
black squares (caused by trying to check Board Status before the game has started and
everyone has picked their colors).

Clear saved game name (Yertle):
Available on any game board page. Only use this if your name is Yertle and you have some
messed up game names. If your name isn't Yertle this will cause your TV to get stuck on a
channel showing marathon episodes of Golden Girls. Girls, girls!

Warfish Turn Poller
¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
A Firefox extension that sits in the status bar and checks Warfish periodically to see if it is your turn.
The latest version of this extension is hosted on mozilla.org and can be found HERE.
To use this extension you need Firefox version 3.0 or higher.
Screenshot:

All screenshots courtesy of DOOM:



To give Feedback, Bug Reports or Feature Requests:

- Use this forum thread.
- Email me at metzgerite@gmail.com
- Post in the discussion area on userscript.org.
- Send smoke signals.

Please note that I may edit any posts you make to this thread. This includes deleting posts that address past issues, consolidating posts or otherwise making it easier for me to keep track of the current requests / problems. I altered the deal, pray I do not alter it any further.

[Reich]

Heya, could you possibly do some work on the forums pages? I'd like to see you add the Warfish page header to over here, to make it all feel more integrated (Orange Box), and to perhaps bring your buttons down to appear like the Warfish 'tabs' (Circle). If you went that route, you'd probably have to do it on both the forums and the game site.

Forumz.png

Status: on hold. Trying to do this is giving me a headache. I might end up making a small script that only runs on the forums and just adds the header on top.

[RiskyBack]

In the Design Tool there is a feature called "View Text" that allows you to see a spreadsheet like view of your country names and modifiers and where they attack. Is there anyway that this could be made editable so we could use the quick multi-country creation add-on and just name the countries whatever1 to start and then go back using that and change the names? If we could do the modifiers that way too, that would be great.

Export/Import into a spreadsheet and back has been added for this page. Still planned is the ability to edit that page in place if you only need to change a few values.

[IRoll11s]

New Version 1.2.0

This new version has a handful of visual updates and a whole lot of refactoring, which I found out means 'going back and fixing all the stupid, slow and ugly code you wrote the first time around'.

You will find your game names (like 'Cool Game' instead of Game 6) reset. This was because I wasn't saving them per player, so if you were using two accounts on the same computer (like me to test), it would erase whatever game names you had saved for the other account. These are now saved per account, and is hopefully the last time you will ever have them disappear. Warfish Turn Poller Extension has also been updated to read the new preference location.

Lots of things will be faster, especially your Game List and Tournament List.

Friend List highlighting is now in more places. It's been added to the huge mess of the Create Tournament page. It was already on the Join Tournament table, but now it's more pronounced and will work when you sort by teams. It's been added to the Tournament Brackets.

Tournament Brackets have some styling added, and will also show games you are in with a different background color to make it much easier to find yourself.

There is a little up-down arrow in the Stage column of your Game List. It doesn't really act like a button yet but it is one, click it to sort your games in order of how long it's been Your Turn, longest to shortest. Dunno why I chose an up-down arrow when it only sorts one way, but that's what it is for now.

Tournament message box is now styled like the message box in game messages.

Styling has been added to the already posted messages to match the message box, when it exists. Sometimes it's not there, so sometimes the messages aren't styled.

The display fix for BAO border modifiers on Map Detail pages now includes an extra listing for percentages, these are the percentage of an attacker killing an army and a defender killing an army. For instance: Dark Jedi 3 (a:+1,+0;d:+0,+0) (64%/75%). The info link that used to appear after every modification is still gone, but the normal Help link in the upper right of the page has been changed to link directly to the BAO help section. Help link is only modified on these pages.

The Sort By drop down box on the Game List now includes the option for Rematches.

[Yertle]

Message area width fixed for next release.

[ElectricMonk]

So I like what you have done to the tournament brackets, but I was wondering if you could take it one step further.

In order to make it easier to police tournaments, could you make a more obvious indicator of games that have a player whose turn time past boot time? Maybe some indicator to show that a player vote to boot is possible, and a different one to indicate host boot is possible?

This sounds just complicated enough to be reasonable. Planned for next version. This got pushed back one version number, still on the list.

[Yertle]

Any known reason why my Tournament games keep falling back to "Game 15" rather than the tournament name? They will be the tournament name for a while (maybe the whole day once I pick them up by going into the game), but the next day (or possibly later in the day), they fall back to "Game #". I'm not deleting cookies or altering anything in anyway, and have just noticed it recently (last update perhaps), and really haven't been able to figure out why (if I close Firefox and bring it back up the tournament name will stay if it was grabbed recently).

Ugh, that didn't make much sense...

Fixed for next release. Once a day the script loads the active game table to delete info for games no longer in that table. If the login page was visited after the request for the active game table was made but before the page was loaded, it would delete everything. This involved almost superhuman timing in order to replicate. Congratulations for finding this one Y.

[Yertle]

Game Over message post causes rematch bug :

Ummmm what's up with when I post a message after a game has finished it creates a Rematch?!?!

Fixed for next release. Way to be consistent with naming your forms Steven.

[IRoll11s]

I uploaded a new version of the script for:

Mapmakers

Fixed the bug where you couldn't add more than 10 borders. You still can't add more than 10 at once, but it will no longer count the 'old' borders as part of the 10.

Fixed the BAO border mix up with attack floor/defense ceiling modifiers. (the WF bug where it had them backwards on modgeom pages).

Major addition is the export/import for the Borders: [View Text] page. Please read the description in the above link for short instructions.

Will be working next on the Interface script to fix a few bugs and to try to finally nail down BAO history view.

[Yertle]

The Display settings quick buttons no longer work, apparently the plugin is losing the Game ID because it goes to an error page with an Invalid Game ID (because it doesn't have the game id in the webpage bar).

[IRoll11s]

hehe i ran across this bug yesterday and fixed it for next release, and was hoping nobody noticed. I'll upload the new version tomorrow.

[CRogue]

I'm extremely excited about the new mapmaker tools, but I'm having a hard time adding multiple borders. If I add a bunch of borders, commit changes, close it, and then open it back up again to add new borders, I can't select any territories that have not been previously connected by a border.

The .csv thing is also exciting for border modifiers, but when I hit view text I don't see the download option as you have it pictured.

[IRoll11s]

I'm extremely excited about the new mapmaker tools, but I'm having a hard time adding multiple borders. If I add a bunch of borders, commit changes, close it, and then open it back up again to add new borders, I can't select any territories that have not been previously connected by a border.

The .csv thing is also exciting for border modifiers, but when I hit view text I don't see the download option as you have it pictured.

I uploaded a new version of the script for:

Mapmakers

The options for .csv export/import should now be available when working on boards. (I had done all my testing on Mods, the Board page was just different enough to break it.)

Your first bug is also fixed. At one point when I thought I had it fixed I clicked on a country and it turned every single damn border on the page green. I almost threw my monitor through the wall. In the end I wound up deleting about 50 lines of code and replacing them with 4. Works great.

I added another menu option: Mapmakers: Odds for Dice Modifiers. This will appear on any design page (right click monkey head, User Script Commands). It returns expected losses for attacker and defender based on a battle where 100 armies are lost. (So it's basically a percentage). It doesn't validate or restrict your input, so don't mess around too much or you'll freeze your browser =]

[IRoll11s]

New Version 1.2.1

Fixed the message display area so that is doesn't scrunch up the messages.
Fixed the bug with the quick UI switcher.
Fixed the bug where posting a message a message in a game that had ended caused a rematch game to be started.
Replacement Game names for Game 6 (for example) will no longer automatically be cleared, it was too buggy.

Biggest change is to the History button. The History was one of the first things I made for this script and I spent too much time making fancy graphs that I bet no one ever looked at because the information wasn't really too relevant. I know I didn't, the only reason I checked it was for the Luck number.

So, there is now a single table with Kills, Losses and Luck. All three columns list the values for Total, Attacking and Defending.

The Luck numbers:

- are accurate for boards with border modifications.
- will work on boards that have abandon on (taking over an empty territory is not especially lucky).
- are summed before rounding.

The above are all limitations that exist in the other Luck plugins available on Warfish, most have all three. So if my luck number do not match the numbers you get in another plugin, mine are right and theirs are not. This is not meant to be arrogant, it's just letting you know why they might be different.

I will be leaving on vacation for 10 days shortly. You probably have about a day after you read this to find and report any catastrophic bugs... if not you gotta wait 10 days =]

[Vataro]

The Map and Decline buttons in the tournament invitation area are doubled.